Skip to content

Kilted #5514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2025
Merged

Kilted #5514

merged 3 commits into from
Jul 8, 2025

Conversation

Tenveis
Copy link
Contributor

@Tenveis Tenveis commented May 3, 2025

updated the instruction to add optional dependency in package.xml for ros2/kilted_tutorial_party#536

Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement! I just have two minor suggestions.

Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once @christophebedard 's comments are resolved.

Co-authored-by: Christophe Bedard <[email protected]>
Signed-off-by: Katherine Scott <[email protected]>
Copy link
Collaborator

@kscottz kscottz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me.

@ahcorde
Copy link
Contributor

ahcorde commented Jul 8, 2025

https://github.com/Mergifyio backport rolling jazzy humble

Copy link
Contributor

mergify bot commented Jul 8, 2025

backport rolling jazzy humble

✅ Backports have been created

@ahcorde ahcorde merged commit b3f4ece into ros2:kilted Jul 8, 2025
5 checks passed
mergify bot pushed a commit that referenced this pull request Jul 8, 2025
Signed-off-by: Katherine Scott <[email protected]>
Co-authored-by: Katherine Scott <[email protected]>
Co-authored-by: Christophe Bedard <[email protected]>
(cherry picked from commit b3f4ece)
mergify bot pushed a commit that referenced this pull request Jul 8, 2025
Signed-off-by: Katherine Scott <[email protected]>
Co-authored-by: Katherine Scott <[email protected]>
Co-authored-by: Christophe Bedard <[email protected]>
(cherry picked from commit b3f4ece)
mergify bot pushed a commit that referenced this pull request Jul 8, 2025
Signed-off-by: Katherine Scott <[email protected]>
Co-authored-by: Katherine Scott <[email protected]>
Co-authored-by: Christophe Bedard <[email protected]>
(cherry picked from commit b3f4ece)
ahcorde pushed a commit that referenced this pull request Jul 8, 2025
(cherry picked from commit b3f4ece)

Signed-off-by: Katherine Scott <[email protected]>
Co-authored-by: Vaibhav Shende <[email protected]>
Co-authored-by: Katherine Scott <[email protected]>
Co-authored-by: Christophe Bedard <[email protected]>
ahcorde pushed a commit that referenced this pull request Jul 8, 2025
(cherry picked from commit b3f4ece)

Signed-off-by: Katherine Scott <[email protected]>
Co-authored-by: Vaibhav Shende <[email protected]>
Co-authored-by: Katherine Scott <[email protected]>
Co-authored-by: Christophe Bedard <[email protected]>
ahcorde pushed a commit that referenced this pull request Jul 8, 2025
(cherry picked from commit b3f4ece)

Signed-off-by: Katherine Scott <[email protected]>
Co-authored-by: Vaibhav Shende <[email protected]>
Co-authored-by: Katherine Scott <[email protected]>
Co-authored-by: Christophe Bedard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants