-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Kilted #5514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kilted #5514
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improvement! I just have two minor suggestions.
source/Tutorials/Beginner-Client-Libraries/Using-Parameters-In-A-Class-Python.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Beginner-Client-Libraries/Using-Parameters-In-A-Class-Python.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm once @christophebedard 's comments are resolved.
Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Katherine Scott <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me.
https://github.com/Mergifyio backport rolling jazzy humble |
✅ Backports have been created
|
Signed-off-by: Katherine Scott <[email protected]> Co-authored-by: Katherine Scott <[email protected]> Co-authored-by: Christophe Bedard <[email protected]> (cherry picked from commit b3f4ece)
Signed-off-by: Katherine Scott <[email protected]> Co-authored-by: Katherine Scott <[email protected]> Co-authored-by: Christophe Bedard <[email protected]> (cherry picked from commit b3f4ece)
Signed-off-by: Katherine Scott <[email protected]> Co-authored-by: Katherine Scott <[email protected]> Co-authored-by: Christophe Bedard <[email protected]> (cherry picked from commit b3f4ece)
(cherry picked from commit b3f4ece) Signed-off-by: Katherine Scott <[email protected]> Co-authored-by: Vaibhav Shende <[email protected]> Co-authored-by: Katherine Scott <[email protected]> Co-authored-by: Christophe Bedard <[email protected]>
(cherry picked from commit b3f4ece) Signed-off-by: Katherine Scott <[email protected]> Co-authored-by: Vaibhav Shende <[email protected]> Co-authored-by: Katherine Scott <[email protected]> Co-authored-by: Christophe Bedard <[email protected]>
(cherry picked from commit b3f4ece) Signed-off-by: Katherine Scott <[email protected]> Co-authored-by: Vaibhav Shende <[email protected]> Co-authored-by: Katherine Scott <[email protected]> Co-authored-by: Christophe Bedard <[email protected]>
updated the instruction to add optional dependency in package.xml for ros2/kilted_tutorial_party#536